Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the view-generator package to version 4.0.0, introducing breaking changes to the generated View and ViewModel templates to align with a new framework architecture.
Key Changes:
- Refactored View/ViewModel templates to use constructor-based dependency injection instead of bind/unbind pattern
- Added lifecycle methods (initialize, onEnter, onExit) to generated View classes
- Updated recommended Node.js version from 18 to 22
- Upgraded development dependencies and GitHub Actions workflow configurations
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated Node version requirement, refactored View/ViewModel templates to use DI pattern with lifecycle methods, added underscore support to route name splitting |
| package.json | Major version bump to 4.0.0, updated dev dependencies (@eslint, @typescript-eslint, globals) and @types/node |
| package-lock.json | Synchronized lockfile with package.json updates, replaced fast-glob with tinyglobby, updated all dependency versions |
| .github/workflows/publish.yml | Updated to Node 24, attempted upgrade to actions v6 (non-existent), added npm global update step |
| .github/workflows/lint.yml | Updated to Node 24, attempted upgrade to actions v6 (non-existent), added npm global update step and explicit node-version configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import fs from "fs"; | ||
|
|
||
| const recommendeVersion: number = 18; | ||
| const recommendeVersion: number = 22; |
There was a problem hiding this comment.
Typo in variable name: "recommendeVersion" should be "recommendedVersion" (missing 'd'). This typo also exists in the original code at line 11 where it's used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.