Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the any usage from the public Sprite.hitArea type to make the API more strictly typed, and bumps the player/package version accordingly.
Changes:
- Update
Sprite.hitAreafromISprite<any> | nulltoISprite<Sprite> | null - Bump player/package version
3.0.3→3.0.4 - Update dev dependency versions (TypeScript ESLint + jsdom) and refresh
package-lock.json
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/index.ts | Updates the console banner to show version 3.0.4. |
| packages/display/src/Sprite.ts | Tightens hitArea typing to remove any. |
| package.json | Bumps package version and updates dev dependency ranges. |
| package-lock.json | Syncs lockfile with updated dependencies and version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/display/src/Sprite.ts
Outdated
| @@ -55,7 +55,7 @@ export class Sprite extends DisplayObjectContainer | |||
| * @type {Sprite|null} | |||
| * @private | |||
There was a problem hiding this comment.
hitArea is declared as public, but its JSDoc still marks it as @private. Since this property is part of the documented Sprite API (see specs) and is publicly accessible, the @private tag is misleading; update the JSDoc to @public (or make the field actually private if that was intended).
| * @private | |
| * @public |
| { | ||
| "name": "@next2d/player", | ||
| "version": "3.0.3", | ||
| "version": "3.0.4", |
There was a problem hiding this comment.
This release bumps the package version from 3.0.3 to 3.0.4, but it also tightens the public TypeScript type of Sprite.hitArea (from any to Sprite). If you’re following semver for type definitions, consider whether a patch bump is sufficient or whether this should be documented as a breaking change for TS consumers (or bumped as a minor version).
| "version": "3.0.4", | |
| "version": "3.1.0", |
No description provided.