Skip to content

#242 update github actions #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ienaga merged 1 commit into from
Feb 10, 2026
Merged

#242 update github actions #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,36 @@ jobs:
- run: npm install -g npm@latest
- run: npm install
- run: npm run publish:dist
- name: Publish packages
run: |
find ./dist -name "package.json" -not -path "*/node_modules/*" -exec dirname {} \; | while read dir; do
npm publish --workspace="${dir}"
done
- run: npm publish
working-directory: ./dist/src
- run: npm publish
working-directory: ./dist/packages/cache
Comment on lines +27 to +30
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow publishes ./dist/src first, but scripts/publish.js rewrites dist/src/package.json to depend on the @next2d/* packages (published later). This can create a window where the newly published @next2d/player version cannot be installed because its dependencies at the same version aren't available yet. Publish the dependency packages first and ./dist/src last (or use a staging tag and promote after all packages are published).

Copilot uses AI. Check for mistakes.
- run: npm publish
working-directory: ./dist/packages/core
Comment on lines +27 to +32
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm publish steps don't provide any auth (NODE_AUTH_TOKEN / npm token). With only setup-node and registry-url, publishes will fail unless the token is injected elsewhere. Consider setting NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} (or equivalent) at the job or step level so all publish steps authenticate consistently.

Copilot uses AI. Check for mistakes.
- run: npm publish
working-directory: ./dist/packages/display
- run: npm publish
working-directory: ./dist/packages/events
- run: npm publish
working-directory: ./dist/packages/filters
- run: npm publish
working-directory: ./dist/packages/geom
- run: npm publish
working-directory: ./dist/packages/media
- run: npm publish
working-directory: ./dist/packages/net
- run: npm publish
working-directory: ./dist/packages/render-queue
- run: npm publish
working-directory: ./dist/packages/renderer
- run: npm publish
working-directory: ./dist/packages/text
- run: npm publish
working-directory: ./dist/packages/texture-packer
- run: npm publish
working-directory: ./dist/packages/ui
- run: npm publish
working-directory: ./dist/packages/webgl
- run: npm publish
working-directory: ./dist/packages/webgpu
Comment on lines +27 to +58
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hard-coded list of npm publish directories will require manual updates whenever packages are added/removed/renamed. The previous approach was dynamic; consider replacing the repeated steps with a small shell loop over ./dist/src and ./dist/packages/* (optionally in a dependency-safe order) to reduce drift and maintenance burden.

Suggested change
- run: npm publish
working-directory: ./dist/src
- run: npm publish
working-directory: ./dist/packages/cache
- run: npm publish
working-directory: ./dist/packages/core
- run: npm publish
working-directory: ./dist/packages/display
- run: npm publish
working-directory: ./dist/packages/events
- run: npm publish
working-directory: ./dist/packages/filters
- run: npm publish
working-directory: ./dist/packages/geom
- run: npm publish
working-directory: ./dist/packages/media
- run: npm publish
working-directory: ./dist/packages/net
- run: npm publish
working-directory: ./dist/packages/render-queue
- run: npm publish
working-directory: ./dist/packages/renderer
- run: npm publish
working-directory: ./dist/packages/text
- run: npm publish
working-directory: ./dist/packages/texture-packer
- run: npm publish
working-directory: ./dist/packages/ui
- run: npm publish
working-directory: ./dist/packages/webgl
- run: npm publish
working-directory: ./dist/packages/webgpu
- run: |
set -e
# Publish core source package first
if [ -f "./dist/src/package.json" ]; then
(cd ./dist/src && npm publish)
fi
# Publish all built packages dynamically
for dir in ./dist/packages/*; do
if [ -d "$dir" ] && [ -f "$dir/package.json" ]; then
(cd "$dir" && npm publish)
fi
done

Copilot uses AI. Check for mistakes.
- run: npm run clean
Loading