Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Next2D Player to version 2.13.1 with several key changes including texture packing algorithm improvements, dependency updates, and preparation for WebGPU support.
Key Changes:
- Version bump from 2.13.0 to 2.13.1
- Refactored texture packing algorithm to optimize padding calculations
- Updated @eslint/eslintrc dependency and added @webgpu/types
- Code improvements in Node object pool management
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated version string in console output from 2.13.0 to 2.13.1 |
| package.json | Bumped version, updated @eslint/eslintrc, added @webgpu/types and @next2d/webgpu workspace |
| package-lock.json | Updated lockfile with version changes and dependency updates (integrity fields removed) |
| packages/texture-packer/src/Node/service/NodeInsertService.ts | Optimized padding calculation logic by moving it after exact fit check |
| packages/texture-packer/src/Node.ts | Refactored create method to use ternary operator and ensure consistent property initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@typescript-eslint/eslint-plugin": "^8.48.0", | ||
| "@typescript-eslint/parser": "^8.48.0", | ||
| "@vitest/web-worker": "^4.0.14", | ||
| "@webgpu/types": "^0.1.66", |
There was a problem hiding this comment.
[nitpick] The @webgpu/types package is added as a devDependency but doesn't appear to be used anywhere in the codebase yet. While it's common to add type definitions in preparation for future work, consider whether this dependency should be added in this PR or deferred to when WebGPU support is actually implemented.
This is especially relevant since the corresponding @next2d/webgpu workspace also doesn't exist yet.
| "@webgpu/types": "^0.1.66", |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.