Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Next2D Player to version 2.12.0 with a bug fix for Stage's addChild method and adds comprehensive test coverage for the Stage class.
- Version bumped from 2.11.0 to 2.12.0 across package files
- Fixed root map logic in Stage.addChild() to correctly set the display object as its own root
- Added comprehensive unit tests for the Stage class
- Updated dev dependencies (@typescript-eslint packages and vitest)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated version string in console log to 2.12.0 |
| packages/display/src/Stage.ts | Fixed addChild method to set root map after parent addChild call, ensuring correct root assignment |
| packages/display/src/Stage.test.ts | Added comprehensive test suite for Stage class covering initialization, properties, and addChild behavior |
| package.json | Updated package version to 2.12.0 and dev dependencies |
| package-lock.json | Updated lockfile with new version and dependency resolutions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.