Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request represents a version 2.11.0 release with a critical bugfix for scissor test state management and dependency updates.
- Fixed scissor test state restoration issue (GitHub issue #234) by replacing a service call with direct GL calls
- Bumped version from 2.10.0 to 2.11.0 across the project
- Updated development dependencies (vitest, vite, rollup) to their latest patch versions
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated console log version string to 2.11.0 |
| packages/webgl/src/Shader/GradientLUTGenerator/usecase/GradientLUTGenerateShapeTextureUseCase.ts | Fixed scissor test state restoration bug by replacing service call with direct GL enable/scissor calls and removed unused import |
| packages/webgl/src/Shader/GradientLUTGenerator/usecase/GradientLUTGenerateShapeTextureUseCase.test.ts | Added comprehensive test coverage for the scissor test bugfix with multiple test cases verifying proper state restoration |
| package.json | Bumped version to 2.11.0 and updated dev dependencies (vitest 4.0.12, vite 7.2.4, rollup 4.53.3) |
| package-lock.json | Updated lockfile to match package.json dependency changes and cleaned up peer dependency flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.