Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Next2D Player from version 2.8.0 to 2.9.0, fixing a critical operator precedence bug in color calculations and adding comprehensive test coverage for the affected components.
Key Changes:
- Fixed operator precedence bug in RGB color extraction (bitwise AND operations now properly grouped before division)
- Added comprehensive test suites for CommandRenderUseCase and CommandCaptureUseCase with 31 total test cases
- Updated vitest and related testing dependencies from 4.0.8 to 4.0.9
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated version display from 2.8.0 to 2.9.0 in console output |
| packages/renderer/src/Command/usecase/CommandRenderUseCase.ts | Fixed operator precedence bug by adding parentheses around bitwise operations in RGB color extraction |
| packages/renderer/src/Command/usecase/CommandRenderUseCase.test.ts | Added comprehensive test suite with 16 test cases covering background color rendering, resize handling, and method call ordering |
| packages/renderer/src/Command/usecase/CommandCaptureUseCase.ts | Fixed operator precedence bug by adding parentheses around bitwise operations in RGB color extraction |
| packages/renderer/src/Command/usecase/CommandCaptureUseCase.test.ts | Added comprehensive test suite with 15 test cases covering image capture with various background colors and canvas sizes |
| package.json | Updated version to 2.9.0 and vitest-related dependencies from 4.0.8 to 4.0.9 |
| package-lock.json | Updated lockfile to reflect version 2.9.0 and updated dependency resolutions for vitest packages and transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const expectedR = (0x80) / 255; | ||
| const expectedG = (0x80) / 255; | ||
| const expectedB = (0x80) / 255; | ||
|
|
There was a problem hiding this comment.
There is trailing whitespace at the end of line 207. This should be removed to maintain code cleanliness.
Suggested change
| const renderQueue = new Float32Array([-1]); | ||
| const imageBitmaps = null; | ||
|
|
||
| const result = execute(renderQueue, imageBitmaps); |
There was a problem hiding this comment.
the function execute does not return anything, yet the return value is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.