Remove redundant void function return value test#220
Merged
Conversation
Merged
Co-authored-by: ienaga <4123454+ienaga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on pull request 214
Remove redundant void function return value test
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes an unnecessary test case and cleans up package-lock.json metadata. The changes streamline test case numbering and remove redundant peer: true flags from package entries.
Key changes:
- Removed test case 7 which tested for undefined return value (redundant test)
- Renumbered subsequent test cases (8→7, 9→8, 10→9) for consistency
- Removed
peer: trueflags from multiple package entries in package-lock.json
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/text/src/TextField/usecase/TextFieldSelectAllUseCase.test.ts | Removed redundant test case and renumbered remaining tests |
| package-lock.json | Cleaned up peer: true flags from package metadata entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #214 regarding test case that unnecessarily captured and tested the return value of a void function.
Changes
TextFieldSelectAllUseCase.test.tsthat capturedexecute()return valueThe
executefunction is typed to returnvoid, making the assertionexpect(result).toBeUndefined()redundant. Function behavior is already covered by existing tests that verify side effects on the TextField object.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.