Skip to content

Comments

Remove redundant void function return value test#220

Merged
ienaga merged 2 commits intodevelopfrom
copilot/sub-pr-214-please-work
Oct 31, 2025
Merged

Remove redundant void function return value test#220
ienaga merged 2 commits intodevelopfrom
copilot/sub-pr-214-please-work

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

Addresses review feedback on PR #214 regarding test case that unnecessarily captured and tested the return value of a void function.

Changes

  • Removed test case7 in TextFieldSelectAllUseCase.test.ts that captured execute() return value
  • Renumbered remaining test cases (8→7, 9→8, 10→9)

The execute function is typed to return void, making the assertion expect(result).toBeUndefined() redundant. Function behavior is already covered by existing tests that verify side effects on the TextField object.

// Before - unnecessary pattern
const result = execute(textField);
expect(result).toBeUndefined();

// After - removed (other tests cover behavior)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ienaga <4123454+ienaga@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on pull request 214 Remove redundant void function return value test Oct 31, 2025
Copilot AI requested a review from ienaga October 31, 2025 23:11
@ienaga ienaga marked this pull request as ready for review October 31, 2025 23:16
Copilot AI review requested due to automatic review settings October 31, 2025 23:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes an unnecessary test case and cleans up package-lock.json metadata. The changes streamline test case numbering and remove redundant peer: true flags from package entries.

Key changes:

  • Removed test case 7 which tested for undefined return value (redundant test)
  • Renumbered subsequent test cases (8→7, 9→8, 10→9) for consistency
  • Removed peer: true flags from multiple package entries in package-lock.json

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/text/src/TextField/usecase/TextFieldSelectAllUseCase.test.ts Removed redundant test case and renumbered remaining tests
package-lock.json Cleaned up peer: true flags from package metadata entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ienaga ienaga merged commit 4e64173 into develop Oct 31, 2025
18 checks passed
@ienaga ienaga deleted the copilot/sub-pr-214-please-work branch November 1, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants