Fix test capturing return value from void function#217
Merged
Conversation
Merged
Co-authored-by: ienaga <4123454+ienaga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback from pull request #214
Fix test capturing return value from void function
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates test assertions and removes unnecessary peer: true flags from package-lock.json dependencies.
- Test case 6 refactored to use
toThrow()assertion instead of checkingtoBeUndefined() - Removed
peer: trueflags from multiple npm package entries in package-lock.json
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/text/src/TextField/usecase/TextFieldSelectedFocusMoveUseCase.test.ts | Updated test case 6 to verify the function doesn't throw instead of checking for undefined return value, improving test clarity |
| package-lock.json | Removed peer: true flags from various package entries to correct dependency metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #214: test case was capturing the return value of
execute(), which is declared asvoid.Changes
TextFieldSelectedFocusMoveUseCase.test.tsto not capture the return valueBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.