Skip to content

#201 AnimationToolからのVideoの受け取り処理の型改修 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ienaga merged 1 commit into from
Aug 6, 2025
Merged

#201 AnimationToolからのVideoの受け取り処理の型改修 #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/media/src/Video/usecase/VideoBuildFromCharacterUseCase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const execute = (video: Video, character: IVideoCharacter): void =>
video.volume = character.volume;

Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential null pointer exception when accessing character.videoData.buffer. Since videoData can now be null (as per the interface update), this will throw an error if character.videoData is null. Add a null check before accessing the buffer property.

Suggested change
if (!character.videoData) return;

Copilot uses AI. Check for mistakes.
video.src = URL.createObjectURL(new Blob(
[character.videoData],
[character.videoData.buffer as ArrayBuffer],
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type casting as ArrayBuffer suggests uncertainty about the actual type. Consider using proper type guards or validation to ensure the buffer property exists and is of the expected type before casting.

Suggested change
[character.videoData.buffer as ArrayBuffer],
[ArrayBuffer.isView(character.videoData) ? character.videoData.buffer : new ArrayBuffer(0)],

Copilot uses AI. Check for mistakes.
{ "type": "video/mp4" }
));
};
2 changes: 1 addition & 1 deletion packages/media/src/interface/IVideoCharacter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export interface IVideoCharacter {
symbol?: string;
extends: string;
buffer: number[] | null;
videoData: Uint8Array;
videoData: null | Uint8Array;
volume: number;
loop: boolean;
autoPlay: boolean;
Expand Down
Loading