Skip to content

Comments

develop#55

Merged
ienaga merged 4 commits intomainfrom
develop
Dec 1, 2025
Merged

develop#55
ienaga merged 4 commits intomainfrom
develop

Conversation

@ienaga
Copy link
Member

@ienaga ienaga commented Dec 1, 2025

No description provided.

Copilot AI and others added 4 commits December 1, 2025 04:57
Co-authored-by: ienaga <4123454+ienaga@users.noreply.github.com>
Fix typo: recommendeVersion → recommendedVersion
Copilot AI review requested due to automatic review settings December 1, 2025 09:01
@ienaga ienaga merged commit d8dded9 into main Dec 1, 2025
15 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a spelling error in the source code and restructures the GitHub Actions publish workflow to align with modern npm publishing practices. The changes include fixing a typo in a variable name and attempting to transition from token-based to OIDC-based npm authentication.

Key Changes:

  • Fixed spelling: recommendeVersionrecommendedVersion across all references in the Node.js version check
  • Restructured publish workflow with workflow-level permissions and renamed job from "build" to "publish"
  • Modified npm publish authentication approach by removing NODE_AUTH_TOKEN and adding id-token: write permission

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/index.ts Corrected variable name typo from "recommendeVersion" to "recommendedVersion" in Node.js version validation logic
.github/workflows/publish.yml Restructured workflow permissions, renamed job to "publish", and modified npm authentication approach

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }} No newline at end of file
- run: npm publish No newline at end of file
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of NODE_AUTH_TOKEN from the npm publish step may cause authentication failures unless npm is configured to use provenance-based publishing with OIDC (which the id-token: write permission suggests).

Ensure that:

  1. The npm package is configured to accept provenance-based publishing
  2. The GitHub Actions environment is properly set up for OIDC authentication with npm
  3. The package repository settings on npm allow for this authentication method

If provenance publishing is not set up, the npm publish command will fail with an authentication error. Consider adding --provenance flag to the publish command to explicitly enable provenance: npm publish --provenance

Suggested change
- run: npm publish
- run: npm publish --provenance

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants