Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the publish workflow with changes to GitHub Actions versions and npm installation steps. The modifications appear to downgrade action versions and add redundant dependency installation commands.
- Downgrades GitHub Actions from v5 to v4 for checkout and setup-node
- Adds npm upgrade step before dependency installation
- Introduces duplicate dependency installation steps (both
npm installandnpm ci)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: "22.x" | ||
| registry-url: "https://registry.npmjs.org" | ||
| - run: npm install -g npm@latest | ||
| - run: npm install |
There was a problem hiding this comment.
Running both npm install and npm ci is redundant and incorrect. The npm ci command removes node_modules and installs from the lockfile for reproducible builds, making the preceding npm install unnecessary. Remove line 22 and keep only npm ci for CI/CD environments.
Suggested change
| - run: npm install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.