Skip to content

Conversation

@AdrianoCelentano
Copy link
Contributor

@AdrianoCelentano AdrianoCelentano commented May 2, 2020

  • Refactored the registration code.
  • We had "place", "city" and "locality" I renamed all to "locality" just because it was the first naming i saw.
  • Extracted some logic out of the ViewModel: validation, error translating.
  • Prepared error handling, for further steps we need to specify it more.

@dakna
Copy link
Contributor

dakna commented May 5, 2020

Still working on #96 as time permits, running into some errors. On a quick glance, this changes the registration workflow a bit, so I'd rather have this merged before I make changes again.

Copy link
Member

@andre-stefanov andre-stefanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts and check develop state. @dakna did some changes which could influence your PR (or even make it obsolete).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants