Skip to content

fix: EVCacheMemcachedClient timer cache cardinality explosion #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sunjeet merged 1 commit into from
Feb 5, 2026
Merged

fix: EVCacheMemcachedClient timer cache cardinality explosion #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,26 @@ public void complete() {
return rv;
}

private String operationSuccessOrFail(OperationStatus status) {
if(status == null) {
return null;
}
if(status.getStatusCode() == StatusCode.SUCCESS || status.getStatusCode() == StatusCode.ERR_NOT_FOUND || status.getStatusCode() == StatusCode.ERR_EXISTS) {
return EVCacheMetricsFactory.SUCCESS;
}
return EVCacheMetricsFactory.FAIL;
}

private Timer getTimer(String operation, String operationType, OperationStatus status, String hit, String host, long maxDuration) {
String name = ((status != null) ? operation + status.getMessage() : operation );
if(hit != null) name = name + hit;

StringBuilder sb = new StringBuilder(32);
sb.append(operation);
if(operationType != null) sb.append(operationType);
if(status != null) sb.append(operationSuccessOrFail(status));
if(status != null) sb.append(status.getStatusCode().name());
if(hit != null) sb.append(hit);
if(host != null) sb.append(host);
String name = sb.toString();

Timer timer = timerMap.get(name);
if(timer != null) return timer;
Expand All @@ -685,11 +702,7 @@ private Timer getTimer(String operation, String operationType, OperationStatus s
if(operation != null) tagList.add(new BasicTag(EVCacheMetricsFactory.CALL_TAG, operation));
if(operationType != null) tagList.add(new BasicTag(EVCacheMetricsFactory.CALL_TYPE_TAG, operationType));
if(status != null) {
if(status.getStatusCode() == StatusCode.SUCCESS || status.getStatusCode() == StatusCode.ERR_NOT_FOUND || status.getStatusCode() == StatusCode.ERR_EXISTS) {
tagList.add(new BasicTag(EVCacheMetricsFactory.IPC_RESULT, EVCacheMetricsFactory.SUCCESS));
} else {
tagList.add(new BasicTag(EVCacheMetricsFactory.IPC_RESULT, EVCacheMetricsFactory.FAIL));
}
tagList.add(new BasicTag(EVCacheMetricsFactory.IPC_RESULT, operationSuccessOrFail(status)));
tagList.add(new BasicTag(EVCacheMetricsFactory.IPC_STATUS, getStatusCode(status.getStatusCode())));
}
if(hit != null) tagList.add(new BasicTag(EVCacheMetricsFactory.CACHE_HIT, hit));
Expand Down