Skip to content

Fix certs generation#208

Merged
DmitriiRabenok merged 1 commit intomainfrom
fix/actualize-chart
Jan 8, 2026
Merged

Fix certs generation#208
DmitriiRabenok merged 1 commit intomainfrom
fix/actualize-chart

Conversation

@theboringstuff
Copy link
Collaborator

@theboringstuff theboringstuff commented Dec 12, 2025

Problem

Currently there are two problems with certs generation:

  • First, it requires explicit enable/disable. This is incorrect, since certs are mandatory for site-manager webhook, so they should be ALWAYS created, either using custom certs or using certs generation.
  • Currently it is allowed to disable both custom and generated certs at the same time. Also it is allowed to enable both custom and generated certs at the same time. This should not be allowed, it should be either one or another.

Solution

  • Removed tls.generateCerts.enabled option from chart values. Now it is implicitly enabled by default. If custom certs are specified, generated certs get implicitly disabled.
  • Updated chart templates accordingly to select custom/generated certs based on presence/absence of custom crt, key and ca
  • Removed unnecessary annotations from qubership CRD
  • Updated docs to remove mention of this tls.generateCerts.enabled option

@theboringstuff theboringstuff changed the title actualize helm chart Fix certs generation Dec 12, 2025
@theboringstuff theboringstuff marked this pull request as ready for review December 12, 2025 12:33
@DmitriiRabenok DmitriiRabenok merged commit 030cf58 into main Jan 8, 2026
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments