Deprecate XFieldElement::{in, de}crement
#276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
jan-ferdinand
force-pushed
the
jfs/deprecate_decrement
branch
from
f524eeb to
0066576
Compare
jan-ferdinand
force-pushed
the
jfs/deprecate_decrement
branch
from
0066576 to
97fc0b3
Compare
Sword-Smith
approved these changes
Dec 5, 2025
Member
Sword-Smith
left a comment
Sword-Smith
left a comment
There was a problem hiding this comment.
If not used downstream, let's kill! LGTM.
Member
Author
|
It’s a deprecation in part to make sure that it’s not used. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
BFieldElement::{in, de}crementare used in downstream crates, the correspondingXFieldElementmethods are not. With the additional argument, they are even prone to panics.