chore: add more checks for block #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiseln
reviewed
Jul 17, 2025
|
|
||
| // Reject blocks with outdated version | ||
| require!( | ||
| block_header.version >= 4, |
Contributor
There was a problem hiding this comment.
Perhaps we should also reject future versions as an additional safeguard in case we don't update the light client in time?
However, this line matches the reference
olga24912
requested changes
Aug 5, 2025
| use crate::u256::U256; | ||
|
|
||
| pub const ZCASH_MEDIAN_TIME_SPAN: usize = 11; | ||
| pub const MEDIAN_TIME_SPAN: usize = 11; |
Collaborator
There was a problem hiding this comment.
Could you add links to the places where these constants are taken from?
| * Maximum amount of time that a block timestamp is allowed to be ahead of the | ||
| * current local time. | ||
| */ | ||
| pub const MAX_FUTURE_BLOCK_TIME_LOCAL: u32 = 2 * 60 * 60; |
Collaborator
There was a problem hiding this comment.
Could you add to the variable name that this is in SEC?
| ) -> u32 { | ||
| use btc_types::network::ZCASH_MEDIAN_TIME_SPAN; | ||
|
|
||
| if let Some(pow_allow_min_difficulty_blocks_after_height) = |
Collaborator
There was a problem hiding this comment.
We have require checks further down that weren’t triggered before, but now, after moving the code to the end, they might start triggering. Do we want them to trigger?
This was referenced Aug 20, 2025
karim-en
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timestamp and version checks for Bitcoin, Litecoin, Zcash.
The extrta dogecoin cehck should be added in #116