Skip to content

Conversation

@billoley
Copy link
Collaborator

@billoley billoley commented Jan 8, 2026

Make webservice use query starter query logic factory xml files and the config service for properties

The reason for some changes may not be immediately obvious. Here are some hints:

  1. Changes in SpringCDIExtension to create a three layer applicationContext from configuration while remaining backward compatible
  2. Additional spring Configuration classes to inject beans that are expected in XML configuration. Primary reasons are when collections (lists, maps, sets, class structures) are created using yaml but these can't just be substitututed using a PropertiesPlaceholderConfigurer.
  3. Changes to XML or yaml to being the configuration (old vs new) to parity
  4. Changes to unit and integration tests to make them use the new configuration
  5. Tests to compare the compile-time property substitution to the runtime property substitution method of creating a spring application context

@billoley billoley added the Not Ready to Merge This PR should not be merged in yet. label Jan 8, 2026
Comment on lines +11 to +20
<!-- Database properties are retrieved from the database.properties file but can be overridden by system properties
<bean id="propertyPlaceholderConfigurer" class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
<property name="location">
<value>classpath:/datawave/query/database.properties</value>
</property>
<property name="systemPropertiesModeName">
<value>SYSTEM_PROPERTIES_MODE_OVERRIDE</value>
</property>
</bean>
-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

@billoley billoley force-pushed the feature/webservice-use-config-service branch from e70eeb8 to 09c882a Compare January 8, 2026 16:40
apmoriarty
apmoriarty previously approved these changes Jan 8, 2026
@billoley billoley force-pushed the feature/webservice-use-config-service branch 2 times, most recently from 131d59c to 8290e65 Compare January 8, 2026 21:37
@billoley billoley force-pushed the feature/webservice-use-config-service branch from 8290e65 to 04d534d Compare January 8, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not Ready to Merge This PR should not be merged in yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants