Bugfix/sonarq broke us #3360
Open
Bugfix/sonarq broke us #3360
+68
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foster33
previously approved these changes
Jan 7, 2026
apmoriarty
previously approved these changes
Jan 8, 2026
billoley
requested changes
Jan 8, 2026
Comment on lines
37
to
38
| Key end = r.getEndKey(); | ||
| String endCf = (end == null || end.getColumnFamily() == null ? "" : end.getColumnFamily().toString()); |
Collaborator
There was a problem hiding this comment.
Neither end nor endCf are used outside of this block -- recommend leaving this code out
warehouse/query-core/src/main/java/datawave/query/ancestor/AncestorIndexBuildingVisitor.java
Outdated
Show resolved
Hide resolved
Comment on lines
593
to
594
| } else if (fieldName.equals("QUERY_ID")) { | ||
| m.setQueryId(fieldValue); |
Collaborator
There was a problem hiding this comment.
leave this code out -- it was correctly identified as duplicative
Comment on lines
695
to
696
| } else if (fieldName.equals("YIELD_COUNT")) { | ||
| m.setYieldCount(Long.parseLong(fieldValue)); |
Collaborator
There was a problem hiding this comment.
leave this code out -- it was correctly identified as duplicative
…estorIndexBuildingVisitor.java Co-authored-by: Bill Oley <bill.oley@gmail.com>
…ncy/datawave into bugfix/sonarqBrokeUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.