Skip to content

Conversation

@SethSmucker
Copy link
Collaborator

@SethSmucker SethSmucker commented Jan 5, 2026

Summary

  • Add getInstance(String) static method to InMemoryAccumulo for named instance sharing
  • Add clearInstances() method for test cleanup
  • Add new constructors to InMemoryAccumuloClient taking InMemoryAccumulo directly
  • Deprecate InMemoryAccumuloClient(String, InMemoryInstance) constructor
  • Update TableCache/AccumuloTableCache interfaces to use InMemoryAccumulo
  • Update BaseTableCache, AccumuloTableCacheImpl, AccumuloTableCacheBean
  • Update MockLoader, MockAccumuloConfiguration, BulkInputFormat, AccumuloRecordWriter
  • Update RebuildingScannerTestHelper and QueryTestTableHelper
  • Migrate ~60 test files from InMemoryInstance to InMemoryAccumulo
  • Update in-memory-accumulo version to 4.0.5-SNAPSHOT

Dependencies

This PR depends on #3253 being merged first. It builds on top of those changes.

Fixes #2597
Part of #2443

- Remove extends ClientContext from InMemoryAccumuloClient
- Remove extends Connector from InMemoryConnector
- Remove implements Instance from InMemoryInstance
- Delete InMemoryClientInfo.java (used non-public Credentials/ClientInfoImpl)
- Clean up BulkInputFormat TabletLocator usage
- Update PushdownScheduler to remove ClientContext usage

Part of #2443
- Add getInstance(String) static method to InMemoryAccumulo for named instances
- Add clearInstances() method for test cleanup
- Add new constructors to InMemoryAccumuloClient taking InMemoryAccumulo directly
- Deprecate InMemoryAccumuloClient(String, InMemoryInstance) constructor
- Update TableCache/AccumuloTableCache interfaces to use InMemoryAccumulo
- Update BaseTableCache, AccumuloTableCacheImpl, AccumuloTableCacheBean
- Update MockLoader, MockAccumuloConfiguration, BulkInputFormat, AccumuloRecordWriter
- Update RebuildingScannerTestHelper and QueryTestTableHelper
- Migrate ~60 test files from InMemoryInstance to InMemoryAccumulo
- Update in-memory-accumulo version to 4.0.5-SNAPSHOT

Fixes #2597
@SethSmucker
Copy link
Collaborator Author

Stacked PR Notice

This PR is stacked on #3253 and shares files with it.

PR Title Status
#3253 Remove interconnected IMA, Thrift, and ClientImpl BASE - must merge first
#3345 Replace InMemoryInstance with InMemoryAccumulo THIS PR
#3227 Remove non-public clientImpl.* usages DRAFT, also stacked on #3253

Shared files:

  • InMemoryAccumuloClient.java
  • InMemoryClientInfo.java
  • InMemoryConnector.java
  • InMemoryInstance.java
  • BulkInputFormat.java

IMPORTANT: Do NOT merge this until #3253 is merged. After #3253 merges, update this branch:

git checkout task/replace-inmemoryinstance
git merge origin/integration
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace usage of InMemoryInstance with InMemoryAccumulo

2 participants