Replace Charset.forName("UTF-8") with StandardCharsets.UTF_8 #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StandardCharsets.UTF_8 is available since Java 7 and is more efficient
than Charset.forName("UTF-8") because it avoids the lookup overhead
and potential UnsupportedCharsetException.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
foster33
approved these changes
Jan 9, 2026
apmoriarty
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Charset.forName("UTF-8")withStandardCharsets.UTF_8across 15 filesStandardCharsets.UTF_8is more efficient (no lookup overhead) and safer (no runtime exception)Files Changed
core/map-reduce/.../BulkResultsFileOutputMapper.javacore/metrics-reporter/.../StatsDClient.javacore/utils/accumulo-utils/.../ColumnVisibilityHelper.javacore/utils/type-utils/.../OptionallyEncodedString.javacore/utils/type-utils/.../TypedValue.javamicroservices/.../ReferencedValue.javamicroservices/.../QueryMetricHandlerProperties.javamicroservices/.../ShardTableQueryMetricHandler.javawarehouse/query-core/.../QueryStatsDClient.javawarehouse/query-core/.../EventQueryTransformer.javawarehouse/query-core/src/test/.../CreateUidsIteratorTest.javawarehouse/query-core/src/test/.../RemoteEdgeQueryLogicHttpTest.javawarehouse/query-core/src/test/.../RemoteQueryServiceTestUtil.javaweb-services/client/.../AbstractHtmlProviderMessageBodyWriter.javaweb-services/security/src/test/.../RemoteUserOperationsImplHttpTest.javaFixes #3313
Part of #2443
🤖 Generated with Claude Code