-
Notifications
You must be signed in to change notification settings - Fork 17
Fixes for Aviti demux emails #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes for Aviti demux emails #500
Conversation
ssjunnebo
commented
Jan 27, 2026
- Correction of the URL in transfer email
- Send an email if the MismatchThreshold is set to 0 to make sure we don't miss informing the user about it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 26.07% 26.14% +0.07%
==========================================
Files 37 37
Lines 5581 5587 +6
==========================================
+ Hits 1455 1461 +6
Misses 4126 4126 ☔ View full report in Codecov by Sentry. |
| settings_kvs["I1MismatchThreshold"] = str(i1_mm_threshold) | ||
| settings_kvs["I2MismatchThreshold"] = str(i2_mm_threshold) | ||
|
|
||
| if i1_mm_threshold == 0 or i2_mm_threshold == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would send the email even if the mismatch threshold was predetermined to be 0 and there is no index collision (for example when we only have single indexes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I can't see that it does that anywhere. I'm not sure it would send it for those cases anyway, since i1_mm_threshold and i2_mm_threshold come from get_custom_mistmatch_thresholds that only looks at the distance.
aanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok 👍