Skip to content

Conversation

@ssjunnebo
Copy link

  • Correction of the URL in transfer email
  • Send an email if the MismatchThreshold is set to 0 to make sure we don't miss informing the user about it

@ssjunnebo ssjunnebo requested review from FranBonath and aanil January 27, 2026 09:13
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.14%. Comparing base (ccccad2) to head (3e58339).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   26.07%   26.14%   +0.07%     
==========================================
  Files          37       37              
  Lines        5581     5587       +6     
==========================================
+ Hits         1455     1461       +6     
  Misses       4126     4126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

settings_kvs["I1MismatchThreshold"] = str(i1_mm_threshold)
settings_kvs["I2MismatchThreshold"] = str(i2_mm_threshold)

if i1_mm_threshold == 0 or i2_mm_threshold == 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would send the email even if the mismatch threshold was predetermined to be 0 and there is no index collision (for example when we only have single indexes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I can't see that it does that anywhere. I'm not sure it would send it for those cases anyway, since i1_mm_threshold and i2_mm_threshold come from get_custom_mistmatch_thresholds that only looks at the distance.

Copy link
Member

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants