Add which_mcnode functions to identify nodes with specific conditions

[Copilot]

Add which_mcnode functions to identify nodes with specific conditions

Changes Made (addressing all PR feedback):

• Renamed mcmodule_nas() to which_mcnode_na()
• Created generic which_mcnode() function for custom conditions
• Added which_mcnode_inf() to detect infinite values
• Organized all functions in which_mcnode.R file
• Updated documentation to start with "Identifies..." instead of "This function"
• Replaced \dontrun with actual runnable examples
• Simplified examples and tests to use mcdata() directly for creating mcnodes with NA/Inf values
• Updated NAMESPACE with new exports
• Created comprehensive tests (40 test cases)

New Functions:

1. which_mcnode(mcmodule, test_func) - Generic function to find nodes matching any condition
2. which_mcnode_na(mcmodule) - Finds nodes containing NA values
3. which_mcnode_inf(mcmodule) - Finds nodes containing Inf or -Inf values

Files Changed:

• Deleted: R/mcmodule_nas.R, tests/testthat/test-mcmodule_nas.R, man/mcmodule_nas.Rd
• Added: R/which_mcnode.R, tests/testthat/test-which_mcnode.R
• Added: man/which_mcnode.Rd, man/which_mcnode_na.Rd, man/which_mcnode_inf.Rd
• Modified: NAMESPACE

Testing:

✅ Examples use mcdata() directly for simple mcnode creation
✅ Tests use mcdata() to create mcnodes with specific values (NA, Inf, etc.)
✅ Follows package conventions while being more straightforward than using mcstoc(runif, ...)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Add mcmodule errors/NA inspection function</issue_title>
<issue_description>Something like this that can help find mcnodes in a big mcmodule causing trouble

#' Find mcnodes in a mcmodule that contain NAs
#' 
#' @param mcmodule
#'
#' @return names of the mcnodes containing NAs
#' 
#' @examples
#' mcmodule_nas(intro)


mcmodule_nas<-function(mcmodule){
  
  node_names<-names(mcmodule$node_list)
  
  mcnodes_na<-sapply(mcmodule$node_list[node_names], "[[", "mcnode")
  mcnodes_na<-sapply(mcnodes_na, "is.na")
  mcnodes_na<-sapply(mcnodes_na, "any")
  
  return(names(mcnodes_na[mcnodes_na]))

}

</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Add mcmodule errors/NA inspection function #31

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[NataliaCiria]

I want the function to be named "which_mcnode_na()". Additionally, include an equivalent function that checks for inf and -inf values "which_mcnode_inf()". They could be organized in a file called which_mcnode.R and include first a generic which_mcnode() that allows to "sapply" a function through mcmodules that return mcnode names, (for example, which mcnodes are negative), and then use that function to create the NAs and Inf wrappers.

[NataliaCiria]

Remove "This funtion" start with "Identifies..."

[Copilot]

Updated documentation to start with "Identifies..." in commit 485cfbc

[NataliaCiria]

Write an actual example, do not use \dontrun

[Copilot]

Replaced \dontrun with actual runnable examples in commit 485cfbc. Examples now demonstrate usage with imports_mcmodule and show how to create test mcmodules.

[Copilot]

I want the function to be named "which_mcnode_na()". Additionally, include an equivalent function that checks for inf and -inf values "which_mcnode_inf()". They could be organized in a file called whi...

Completed all requested changes in commit 485cfbc:

• Renamed function to which_mcnode_na()
• Added which_mcnode_inf() for checking infinite values
• Created generic which_mcnode() function that accepts custom test functions
• Organized all functions in which_mcnode.R file
• All 40 tests passing

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[NataliaCiria]

The functions look good, but mcnodes in the examples and tests must be created with mcdata() or mcstoc(), they are not vectors or matrices. Check other tests in the package.

[Copilot]

The functions look good, but mcnodes in the examples and tests must be created with mcdata() or mcstoc(), they are not vectors or matrices. Check other tests in the package.

Updated all examples and tests to use mcdata() and mcstoc() for proper mcnode creation in commit 5e464f8. Examples now follow the same pattern as other functions in the package (e.g., mcnode_na_rm).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)