Use separate heating and cooling availability sensors in unmet hours program #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n pan heater and unmet hours programs.
…r natural ventilation too.
shorowit
approved these changes
Jan 26, 2026
Contributor
shorowit
left a comment
shorowit
left a comment
There was a problem hiding this comment.
This probably won't affect the vast majority of users, but this is definitely more correct, nice catch. I made one more related change for natural ventilation (so we can remove the HVAC availability sensor altogether). Assuming no CI diffs after my change, this can merge in. Thanks @joseph-robertson!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If the no-space-heating unavailable period for base-schedules-simple-no-space-heating.xml is widened to 1/1 - 12/31, there are 0.0 reported unmet cooling hours (base-schedules-simple-no-space-heating.xml with the unavailable period removed shows 87.0). With this PR's fix in place, unmet cooling hours is 82.0.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run