Feature/io new

[ekate]

No description provided.

[jgpawletko]

Hi @ekate ,
I'm hesitant to merge this branch in because of the collection-specific code that it contains.
How far away is the collection-based authorization?
If it's OK with the product owners, it would be better to get the collection-based authorization in place and then use it for this collection.

What do you think?
Best-
Joe

[ekate]

I am fine with it. I should be done with collection authorization by
Friday. Could you just look at the data part ?
I also seemed to find out what was the problem with collection_facet and
add this to this PR. Could you look at it too ?

Thank you.

Kate

On Tue, Oct 13, 2015 at 2:42 PM, Joseph Pawletko notifications@github.com
wrote:

Hi @ekate https://github.com/ekate ,
I'm hesitant to merge this branch in because of the collection-specific
code that it contains.
How far away is the collection-based authorization?
If it's OK with the product owners, it would be better to get the
collection-based authorization in place and then use it for this collection.

What do you think?
Best-
Joe

—
Reply to this email directly or view it on GitHub
#182 (comment).

Ekaterina Pechekhonova
Digital Library Programmer/Analyst
New York University
Libraries
email: ekate@nyu.edu
phone: 212-992-9993

[jgpawletko]

Hi Kate,
Yes, I will review the areas you requested.
Best-
Joe

On Tue, Oct 13, 2015 at 2:50 PM, ekate notifications@github.com wrote:

I am fine with it. I should be done with collection authorization by
Friday. Could you just look at the data part ?
I also seemed to find out what was the problem with collection_facet and
add this to this PR. Could you look at it too ?

Thank you.

Kate

On Tue, Oct 13, 2015 at 2:42 PM, Joseph Pawletko <notifications@github.com

wrote:

Hi @ekate https://github.com/ekate ,
I'm hesitant to merge this branch in because of the collection-specific
code that it contains.
How far away is the collection-based authorization?
If it's OK with the product owners, it would be better to get the
collection-based authorization in place and then use it for this
collection.

What do you think?
Best-
Joe

—
Reply to this email directly or view it on GitHub
<#182 (comment)
.

Ekaterina Pechekhonova
Digital Library Programmer/Analyst
New York University
Libraries
email: ekate@nyu.edu
phone: 212-992-9993

—
Reply to this email directly or view it on GitHub
#182 (comment).

[jgpawletko]

Hi @ekate,

In general things look good.
Nice tweak to the collection facet feature.

One question:
I noticed here that you moved the ppXX user from the admin_group to the io_cataloger group.
Do you need this change?

Thanks-
Joe

[ekate]

I did it to test some assertions. Will change back.

On Fri, Oct 16, 2015 at 10:22 AM, Joseph Pawletko notifications@github.com
wrote:

Hi @ekate https://github.com/ekate,

In general things look good.

Nice tweak to the collection facet feature.

One question:
I noticed here
https://github.com/NYULibraries/ichabod/blob/feature/io_new/config/role_map.yml#L10
that you moved the ppXX user from the admin_group to the io_cataloger
group.

Do you need this change?

Thanks-
Joe

—
Reply to this email directly or view it on GitHub
#182 (comment).

Ekaterina Pechekhonova
Digital Library Programmer/Analyst
New York University
Libraries
email: ekate@nyu.edu
phone: 212-992-9993