Feature/login integration

[jgpawletko]

@NYULibraries/hydra

Hi Folks,
I'd like to integrate Hannan's updated login branch to development.
Please let me know what you think. We can also discuss this as a
post-scrum topic.

I'm using this PR to capture the discussion.
There are tests that need to be updated (see @wip additions).
This code will not be merged until the tests have been updated.

Thanks!
Joe

[ckassel]

@jgpawletko - Carol, Esha, and Daniel all say go for it!

On Wed, Jul 15, 2015 at 9:51 AM, Joseph Pawletko notifications@github.com
wrote:

@NYULibraries/hydra https://github.com/orgs/NYULibraries/teams/hydra

Hi Folks,
I'd like to integrate Hannan's updated login branch to development.
Please let me know what you think. We can also discuss this as a
post-scrum topic.

Thanks!

Joe

You can view, comment on, or merge this pull request online at:

#156
Commit Summary

• Update Gemfile to use Omniauth and Devise instead of Authlogic
• Remove all mentions of UserSession. We do not use UserSession anymore
• Remove Authpds controller
• Remove authlogic from User
• Prep user by adding fields for login
• Add devise initializer
• Add omniauth callback controller
• Use the devise routes
• Remove user attributes and port over the data
• Make user omniauthable
• Change session cookie domain to :all
• Run migrations
• Update Gemfile for latest NYULibraries-assets
• Use the new NYULibraries-assets's InstitutionHelper
• Add logout option and the new_session_path method for Devise
• Mark all login jobs as WIP
• A changelog was added to illustrate what changed
• Accidently called a field by the wrong name
• Mark one extra story as WIP
• Reflect WIP scenarios in changelog
• In ichabod, we call it SECRET_KEY_BASE, not SECRET_TOKEN

File Changes

• A CHANGELOG.md
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-0 (12)
• M Gemfile
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-1 (8)
• M Gemfile.lock
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-2 (91)
• M app/controllers/application_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-3 (16)
• D app/controllers/user_sessions_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-4 (11)
• A app/controllers/users/omniauth_callbacks_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-5 (95)
• M app/models/user.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-6 (10)
• D app/models/user_session.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-7 (12)
• A config/initializers/devise.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-8 (13)
• M config/initializers/session_store.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-9 (2)
• M config/routes.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-10 (10)
• A db/migrate/20150702221853_remove_authlogic_fields_from_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-11 (29)
• A db/migrate/20150708185150_add_login_fields_to_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-12 (15)
• A db/migrate/20150708185217_add_username_provider_index_to_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-13 (9)
• A
  db/migrate/20150708185249_populate_user_fields_from_user_attributes.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-14 (15)
• A db/migrate/20150708185305_remove_user_attributes_from_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-15 (9)
• M db/schema.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-16 (8)
• M features/destroy_button_on_results.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-17 (4)
• M features/edit_button_on_results.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-18 (6)
• M features/edit_metadata_authorization.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-19 (8)
• M features/immutable_source.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-20 (11)
• M features/login.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-21 (2)
• M features/metadata_remediation.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-22 (8)
• M features/support/authlogic.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-23 (32)
• D spec/controllers/user_sessions_controller_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-24 (12)
• M spec/factories/users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-25 (1)
• D spec/models/user_session_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-26 (5)
• M spec/models/user_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-27 (5)
• A spec/routing/user_routes_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-28 (35)

Patch Links:

• https://github.com/NYULibraries/ichabod/pull/156.patch
• https://github.com/NYULibraries/ichabod/pull/156.diff

—
Reply to this email directly or view it on GitHub
#156.

Carol Kassel
Senior Manager, Digital Library Infrastructure
NYU Digital Library Technology Services
cmk@nyu.edu
(212) 992-9246
dlib.nyu.edu

[Jenkins-NYULib]

Joe- My only thought is that means you can't merge development back into
master for a while. The Login application that this is integrated with is
not yet live. So keeping it in a separate branch and periodically rebasing
would allow you to continue development -> master pushes until the Login
app is live.

The plan is for this summer, but delays arise and I can't make any promises.

Thanks,

Barnaby Alter
Web Services
Division of Libraries
NYU

On Wed, Jul 15, 2015 at 10:11 AM, ckassel notifications@github.com wrote:

@jgpawletko - Carol, Esha, and Daniel all say go for it!

On Wed, Jul 15, 2015 at 9:51 AM, Joseph Pawletko <notifications@github.com

wrote:

@NYULibraries/hydra https://github.com/orgs/NYULibraries/teams/hydra

Hi Folks,
I'd like to integrate Hannan's updated login branch to development.
Please let me know what you think. We can also discuss this as a
post-scrum topic.

Thanks!

Joe

You can view, comment on, or merge this pull request online at:

#156
Commit Summary

• Update Gemfile to use Omniauth and Devise instead of Authlogic
• Remove all mentions of UserSession. We do not use UserSession anymore
• Remove Authpds controller
• Remove authlogic from User
• Prep user by adding fields for login
• Add devise initializer
• Add omniauth callback controller
• Use the devise routes
• Remove user attributes and port over the data
• Make user omniauthable
• Change session cookie domain to :all
• Run migrations
• Update Gemfile for latest NYULibraries-assets
• Use the new NYULibraries-assets's InstitutionHelper
• Add logout option and the new_session_path method for Devise
• Mark all login jobs as WIP
• A changelog was added to illustrate what changed
• Accidently called a field by the wrong name
• Mark one extra story as WIP
• Reflect WIP scenarios in changelog
• In ichabod, we call it SECRET_KEY_BASE, not SECRET_TOKEN

File Changes

• A CHANGELOG.md
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-0 (12)
• M Gemfile
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-1 (8)
• M Gemfile.lock
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-2 (91)
• M app/controllers/application_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-3 (16)
• D app/controllers/user_sessions_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-4 (11)
• A app/controllers/users/omniauth_callbacks_controller.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-5 (95)
• M app/models/user.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-6 (10)
• D app/models/user_session.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-7 (12)
• A config/initializers/devise.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-8 (13)
• M config/initializers/session_store.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-9 (2)
• M config/routes.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-10 (10)
• A db/migrate/20150702221853_remove_authlogic_fields_from_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-11 (29)
• A db/migrate/20150708185150_add_login_fields_to_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-12 (15)
• A db/migrate/20150708185217_add_username_provider_index_to_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-13 (9)
• A
  db/migrate/20150708185249_populate_user_fields_from_user_attributes.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-14 (15)
• A db/migrate/20150708185305_remove_user_attributes_from_users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-15 (9)
• M db/schema.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-16 (8)
• M features/destroy_button_on_results.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-17 (4)
• M features/edit_button_on_results.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-18 (6)
• M features/edit_metadata_authorization.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-19 (8)
• M features/immutable_source.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-20 (11)
• M features/login.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-21 (2)
• M features/metadata_remediation.feature
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-22 (8)
• M features/support/authlogic.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-23 (32)
• D spec/controllers/user_sessions_controller_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-24 (12)
• M spec/factories/users.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-25 (1)
• D spec/models/user_session_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-26 (5)
• M spec/models/user_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-27 (5)
• A spec/routing/user_routes_spec.rb
  https://github.com/NYULibraries/ichabod/pull/156/files#diff-28 (35)

Patch Links:

• https://github.com/NYULibraries/ichabod/pull/156.patch
• https://github.com/NYULibraries/ichabod/pull/156.diff

—
Reply to this email directly or view it on GitHub
#156.

Carol Kassel
Senior Manager, Digital Library Infrastructure
NYU Digital Library Technology Services
cmk@nyu.edu
(212) 992-9246
dlib.nyu.edu

—
Reply to this email directly or view it on GitHub
#156 (comment).

[jgpawletko]

@barnabyalter @NYULibraries/hydra
Thank you for pointing out that the login app isn't live yet.

I retract my proposal then (:wink:) and we should hold off
on integration.

Please let us know when the login application is live, and then
we'll work toward merging the functionality into development.

Thanks!
Joe

[hab278]

@jgpawletko @NYULibraries/hydra
Hello all, the Login application is now live and in production! With this, we have more of a reason to use the Login integration.

I've updated to contain all the commits in development at the moment of writing. The good news is that this branch will no longer remove columns on the database, making it much more compatible with other branches.

There are still plenty of tests marked with wip that need to be looked at.

Thank you! 👍

[eshadatta]

@hab278 ,

When you're talking about the wip tests, are you talking about the ones marked by us or have you tagged some as wip. Just wanted to confirm. Thanks for your work. So, it should be good to merge, then?

[hab278]

@eshadatta Sorry, I meant I've marked some scenarios as wip. I've committed a4b2c26 and e46eb61 where I marked scenarios as wip. I think all stories previously marked as @loggedin are now wip.

I think it's good to merge, but I'd like for a set of eyes on them, and only when the wip stories are fixed. I marked them as wip so we can deploy and do some quick manual testing.

@barnabyalter wrote an awesome documentation on testing login.

[eshadatta]

@hab278 Thanks