Skip to content

Minor updates to DMSPress and KVzapPress#177

Merged
SimJeg merged 22 commits intomainfrom
simon/dms-kvzap-updates
Jan 27, 2026
Merged

Minor updates to DMSPress and KVzapPress#177
SimJeg merged 22 commits intomainfrom
simon/dms-kvzap-updates

Conversation

@SimJeg
Copy link
Collaborator

@SimJeg SimJeg commented Jan 26, 2026

Minor updates to DMS and KVzap:

  • make clear the DMSPress use dense-prefill and not sparse-prefill
  • fix a future transformer bug for KVzapModel (add self.all_tied_weights_keys = {})
  • also speed up tests using flash-attn wheels and not installing CUDA 12.5

Signed-off-by: SimJeg <sjegou@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: SimJeg <sjegou@nvidia.com>
Signed-off-by: SimJeg <sjegou@nvidia.com>
Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 26, 2026

/ok to test 9e918d3

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 26, 2026

/ok to test 491e868

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 26, 2026

/ok to test d01ca21

Signed-off-by: SimJeg <sjegou@nvidia.com>
Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 26, 2026

/ok to test 2a8f6ad

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 26, 2026

/ok to test d94f1ee

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 7a48bc2

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test ced8066

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 4c69e8c

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 533f9ed

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 8492c86

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test ca92fba

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test ec499b5

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test c76b827

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 2060dfb

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 5637f59

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test f5954e2

Signed-off-by: SimJeg <sjegou@nvidia.com>
@SimJeg
Copy link
Collaborator Author

SimJeg commented Jan 27, 2026

/ok to test 653e255

Signed-off-by: SimJeg <sjegou@nvidia.com>
Copy link
Collaborator

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@SimJeg SimJeg merged commit 68f8ef8 into main Jan 27, 2026
2 checks passed
@SimJeg SimJeg deleted the simon/dms-kvzap-updates branch January 27, 2026 15:51
@SimJeg SimJeg mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants