Update CUDA C++ tutorial to r6 #126
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
bernhardmgruber
changed the title
Author
|
Since @brycelelbach asked me whether the files are stored in LFS, I believe so: |
bernhardmgruber
force-pushed
the
cpp_r6
branch
from
9a19ebe to
a5c2543
Compare
bernhardmgruber
changed the title
Collaborator
|
Can we just call this "r6" nor "r6.1"? I don't want a super complex versioning scheme here, and extra dots in filenames throw off some OSes/tools. |
Author
|
Done |
* Based on r6 from Bryce (fixes typos)
* Added intro slide and team from last/for next "How to Build a CUDA Application in C++, From Start to Finish" course
* Added DLI platform intro slides
* Change namespaces from `dli::` to `ach::`
* Drop Final Review and Final Assignment 4 (should not be public)
* Include the following small fixes:
- slide 34: "Thrust execution policies are inspired them!"
- slide 51: "The median is a number", "To compute THE median"
- slide 103: the mdspan should be reallocated to 10min
- slide 120: the Exercise Segmented Mean is fine in 6min instead of 10
- slide 128: the Exercise Use Explicit Memory Spaces is fine in 10min instead of 12
- slide 171: "work is ordered on THE GPU"
- slide 172: "on THE GPU", "THE default one"
- slide 182: thrust::copy is not done on compute_stream, as stated in the text. The text is wrong, removed it.
- slide 182: wrong variable names, lacking `_`
- slide 195: wrong variable names, lacking `_`
- slide 195: `cudaMemcpy` -> `cudaMemcpyAsync`
- slide 220: "We need the number number of thread"
- slide 240: "check if THE cell index"
- slide 256: "Atomics memory operations", remove `s`
- slide 256: `count[0]` -> `histogram[0]`
- slide 228 and others: replace `row_symmetry_check_kernel` by `symmetry_check_kernel` for consistency with other slides and exercise
Collaborator
|
/ok to test 0efa007 |
brycelelbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dli::toach::The idea is to hide/remove one of the Bryce/Bernhard team intros and brev/DLI intros, depending on who teaches the lecture
I furthermore applied the following fixes discovered during the course given on 2026-01-22: