-
Notifications
You must be signed in to change notification settings - Fork 203
CUDA C++ Contributing Guide #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
|
This pull request contains 1 unsigned commit(s):
All commits must be signed before this PR can be merged. Please sign your commits by following these steps: Option 1: SSH Key Signing (Recommended)
Option 2: GPG Key Signing
For more details, see GitHub's commit signature verification docs. This comment will be updated when you push new commits. |
657cefe to
a6af2d0
Compare
smish-nvidia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
brycelelbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a few minor notes.
|
@gevtushenko the link check is failing because it's failing to find the theoretical source file you reference in the doc. You should add that file path to |
brycelelbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the false positive link check failure. It's failing to find the theoretical source file you reference in the doc.
Error: R] <file:///home/runner/work/accelerated-computing-hub/accelerated-computing-hub/tutorials/cuda-cpp/Solutions/no-magic-execution-space-changes.cpp> | Cannot find file: File not found. Check if file exists and path is correct
You should add that file path to $REPO_ROOT/brev/.lycheeignore.
951d56d to
22d4257
Compare
|
/ok to test 22d4257 |
brycelelbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
No description provided.