Allow for mesh instances without geometry#35
Merged
apanteleev merged 1 commit intoNVIDIA-RTX:mainfrom Oct 9, 2025
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes small modifications to
donut::engine::Scenethat avoids fatal crashes when aMeshInfodoes not have any vertex data or geometries. This does not change existing behaviour for meshes that do have geometries or vertex data.The motivation for this in my situation is to be able to create procedural geometry where all geometry is created within the vertex shader, which is dispatched using
drawIndirect, thus no vertex or index buffers. Inheriting fromMeshInfoandMeshInstanceallows for convenient integration of procedural meshes with the existing Scene and Scene Graph systems, including automatic population of theScene's instance buffer etc without having to re-implement most ofScene's functionality.