Skip to content

Comments

Fix wrong reverse depth detection from proj matrix in planar view#34

Closed
MohammadMDSA wants to merge 1 commit intoNVIDIA-RTX:mainfrom
MohammadMDSA:main
Closed

Fix wrong reverse depth detection from proj matrix in planar view#34
MohammadMDSA wants to merge 1 commit intoNVIDIA-RTX:mainfrom
MohammadMDSA:main

Conversation

@MohammadMDSA
Copy link
Contributor

No description provided.

@apanteleev
Copy link
Collaborator

Thanks - but I think it should be <= and not <. The case when m22 is zero happens on reverse infinite projection matrices, which is what we use in the FeatureDemo and other samples.

@MohammadMDSA
Copy link
Contributor Author

Yes, you are right. I checked I actually fixed it in my project but forgot to publish it.

@apanteleev
Copy link
Collaborator

Applied the change, closing the PR.

@apanteleev apanteleev closed this Oct 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants