Having only single llm call in case of extracting token usage metrics from the ChatNVIDIA connector#390
Open
niyatisingal wants to merge 1 commit intodevelopfrom
Open
Having only single llm call in case of extracting token usage metrics from the ChatNVIDIA connector#390niyatisingal wants to merge 1 commit intodevelopfrom
niyatisingal wants to merge 1 commit intodevelopfrom
Conversation
niyatisingal
force-pushed
the
dev/nsingal/fix-perf-regression
branch
4 times, most recently
from
56e92cf to
29c05c8
Compare
Signed-off-by: Niyati Singal <nsingal@nvidia.com>
niyatisingal
force-pushed
the
dev/nsingal/fix-perf-regression
branch
from
29c05c8 to
48c2d6d
Compare
nv-pranjald
reviewed
Feb 27, 2026
| and hasattr(gen.message, "usage_metadata") | ||
| and gen.message.usage_metadata | ||
| ): | ||
| meta = gen.message.usage_metadata |
Collaborator
There was a problem hiding this comment.
Since we are still relying on metadata to get token information.
Was our ChatNvidia wrapper not processing this information in astream mode even though it was returned by llm?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
git commit -s) and GPG signed (git commit -S).