Skip to content

Mount NSO containers pid namespace for dev-shells. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulrikforsgren wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mount NSO containers pid namespace for dev-shells. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skeletons/ned/testenvs/testenv-common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ check-logs:
# and network namespace of the testenv NSO container. This allows running
# python script and IPython that interface with NSO.
dev-shell:
docker run -it --rm -v $(PROJECT_DIR):/src --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)
docker run -it --rm -v $(PROJECT_DIR):/src --pid container:$(CNT_PREFIX)-nso$(NSO) --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)

# Wait for all containers in the testenv (as found via the testenv label) to
# become healthy! If a container has exited, we exit immediately.
Expand Down
2 changes: 1 addition & 1 deletion skeletons/package/testenvs/testenv-common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ check-logs:
# and network namespace of the testenv NSO container. This allows running
# python script and IPython that interface with NSO.
dev-shell:
docker run -it --rm -v $(PROJECT_DIR):/src --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)
docker run -it --rm -v $(PROJECT_DIR):/src --pid container:$(CNT_PREFIX)-nso$(NSO) --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)

# Wait for all containers in the testenv (as found via the testenv label) to
# become healthy! If a container has exited, we exit immediately.
Expand Down
2 changes: 1 addition & 1 deletion skeletons/system/testenvs/testenv-common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ check-logs:
# and network namespace of the testenv NSO container. This allows running
# python script and IPython that interface with NSO.
dev-shell:
docker run -it --rm -v $(PROJECT_DIR):/src --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)
docker run -it --rm -v $(PROJECT_DIR):/src --pid container:$(CNT_PREFIX)-nso$(NSO) --volumes-from $(CNT_PREFIX)-nso$(NSO) --network container:$(CNT_PREFIX)-nso$(NSO) $(NSO_IMAGE_PATH)cisco-nso-dev:$(NSO_VERSION)

# Wait for all containers in the testenv (as found via the testenv label) to
# become healthy! If a container has exited, we exit immediately.
Expand Down