Skip to content

Proper Keithley Ophyd device#47

Merged
thopkins32 merged 7 commits intomainfrom
keithley
Feb 17, 2026
Merged

Proper Keithley Ophyd device#47
thopkins32 merged 7 commits intomainfrom
keithley

Conversation

@thopkins32
Copy link
Contributor

@thopkins32 thopkins32 commented Feb 5, 2026

Implements an ophyd device to control 2 Keithley devices with 2 channels each (total of 4 device instances).

Had to do some funky stuff with overriding the move to inject a dynamic settle_time based on another PV's scan field. This is how the measurement is done after a move.

@thopkins32 thopkins32 requested a review from jwlodek February 17, 2026 16:33
Copy link

@jwlodek jwlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Comment on lines +11 to +29
# Map EPICS SCAN field string values to seconds
SCAN_PERIOD_MAP = {
"Passive": 0,
"Event": 0,
"I/O Intr": 0,
"300 second": 300.0,
"240 second": 240.0,
"180 second": 180.0,
"120 second": 120.0,
"60 second": 60.0,
"30 second": 30.0,
"10 second": 10.0,
"5 second": 5.0,
"2 second": 2.0,
"1 second": 1.0,
".5 second": 0.5,
".2 second": 0.2,
".1 second": 0.1,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if it'd be worth putting this somewhere reusable? nslsii or ophyd?

@thopkins32 thopkins32 merged commit 8e55b91 into main Feb 17, 2026
4 checks passed
@thopkins32 thopkins32 deleted the keithley branch February 17, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments