Skip to content

removed query parameter and manual header extraction logic #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
padraic-shafer merged 1 commit into from
Feb 9, 2026
Merged

removed query parameter and manual header extraction logic #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/nsls2api/api/v1/user_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import asyncio

import fastapi
from fastapi import HTTPException, Request
from fastapi import HTTPException, Request, Header

from nsls2api.api.models.person_model import DataSessionAccess, LDAPUserResponse, Person
from nsls2api.infrastructure.security import get_settings
Expand Down Expand Up @@ -74,9 +74,8 @@ async def get_person_by_department(department_code: str = "PS"):

# TODO: Add back into schema if we decide to use this endpoint.
@router.get("/person/me",include_in_schema=True)
async def get_myself(request: Request, upn: str= None):
#User principal name
upn = upn or request.headers.get("upn")
async def get_myself(upn: str = Header(...)):
#upn: User principal name
if not upn:
raise HTTPException(status_code=400, detail = "upn not found")
settings = get_settings()
Expand Down