argument order for filter and threshold changed in find_photons()

[ambarb]

See #24

just switched 250 and 3 in the call to find_photons()

Left output in place as this is how it was rendered before this PR

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ambarb]

@stuwilkins or @stuartcampbell i see that you two are the ones associated with this repo. I cannot ask for your explicit review on the right-hand side at the top.

I don't know how to fix the things that failed (or which ones can be safely ignored).

We ran the notebook and code using python3.9. We used scipy environment on jupyterhub so the available centroids is:

[ambarb]

found possible mistake, need to update

[mrakitin]

@ambarb, I've created a tag v0.2.0rc3, this change can go into the next release candidate. How ready is your PR?
My plan is to rework the CI for this repository to use GitHub Actions rather than Azure DevOps - that way we can have better CI runs.

[ambarb]

@mrakitin no. there is a mistake here and I need to look back at my slack conversation with the summer student that spend the summer looking at the c-code.

@padraic-shafer FYI given your question on slack

[ambarb]

@mrakitin i fixed the notebook that had the wrong argument

for this branch, the version is:

pycentroids._pycentroids.__version__

'67bb8de+'

do i need to do anything to get the correct tag? The notebook example that is in production shows tag associated with a version release. see the last cell. mine is just a generic commit

as for the results, added None for what I am assuming is the new filter argment finds the same number of of possible events, but some of the finer details make it appear there are some improvements in reducing more outliers.