Replace Black and Flake8 with Ruff#103
Merged
ambarb merged 5 commits intoNSLS-II-CSX:masterfrom Jul 10, 2025
Merged
Conversation
Contributor
|
While we're here, let's get this green :) This function looks like it assumes some generic Can we modify that in this PR to consume those as required keyword arguments, so they are clearly available in the lower closure? |
Contributor
Author
|
Member
|
@maffettone we addressed those issues. I don't want to close the #97 because we need to reorganize now to have generic image data helpers, but the linting issues have all been addressed. I am good to merge this |
ambarb
approved these changes
Jul 10, 2025
maffettone
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces Black and Flake8 with Ruff for formatting and linting, addressing #102 and #93 .
Removed Black and Flake8
Added Ruff to requirements.txt
Applied Ruff auto-fixes to format code
Configuration remains implicit; no changes to pyproject.toml were made.