Fixes TBD unit test for good/bad derating cases #2070
Merged
+84
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgix
commented
Dec 28, 2025
| if attic | ||
| if boundary == "outdoors" | ||
| assert(TBD.rsi(lc) < 1.0, err_msg) # uninsulated | ||
| assert(TBD.rsi(lc, film) < 1.0, err_msg) # uninsulated |
brgix
commented
Dec 28, 2025
| uo = prop.get | ||
| # puts "#{id} : #{uo.round(3)} vs #{(1/TBD.rsi(lc)).round(3)}" | ||
| unless option == 'uprate' | ||
| assert_empty(prop, err_msg) |
Collaborator
Author
There was a problem hiding this comment.
(New) AdditionalProperty not yet enabled for simple derating cases.
brgix
commented
Dec 29, 2025
| lload = activity.liveload | ||
|
|
||
| if cat.respond_to?(:to_s) | ||
| if cat.respond_to?(:to_sym) |
Collaborator
Author
There was a problem hiding this comment.
Preferable to check for symbols than stringable objects, then convert to strings.
brgix
commented
Dec 29, 2025
| case @@data[:category] | ||
| when "commerce" then partition_m2 = floor_m2 / 2 | ||
| when "industry" then partition_m2 = floor_m2 / 4 | ||
| when "recreation" then partition_m2 = floor_m2 / 3 |
Collaborator
Author
There was a problem hiding this comment.
A deeper dive may be required to adjust non-modelled partition m2 / floor area m2. Best guesstimate for now.
brgix
commented
Dec 29, 2025
| # | ||
| # Upon initialization, only the :structure tally is set. It is assumed | ||
| # that structure (and main framing) do not change with NECB U-factor | ||
| # requirements, e.g.: |
Collaborator
Author
There was a problem hiding this comment.
Embodied carbon linked to modelled surfaces (e.g. envelope), now calculated elsewhere in BTAP.
Collaborator
|
Merged, thank you Denis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of branch nrcan_476:
@nicholaspneu : merge with nrcan_476 at your convenience.