subclassing plant_loop_prm_baseline_condenser_water_temperatures for 90.1-2016 and 2019
#1916
Conversation
lymereJ
left a comment
lymereJ
left a comment
There was a problem hiding this comment.
@JanghyunJK - Thanks for this PR, it does look this is indeed missing from the code base. This is a PRM requirement, specifically for the "stable" PRM baseline so it should be under the ASHRAE901PRM class, not ASHRAE9012016 and ASHRAE9012019, unless of course there is a need for it outside of the PRM class.
| # Limit the OATwb | ||
| if design_oat_wb_f < 55 | ||
| design_oat_wb_f = 55 | ||
| OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.PlantLoop', "For #{plant_loop.name}, a design OATwb of 55F will be used for sizing the cooling towers because the actual design value is below the limit in G3.1.3.11.") | ||
| elsif design_oat_wb_f > 90 | ||
| design_oat_wb_f = 90 | ||
| OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.PlantLoop', "For #{plant_loop.name}, a design OATwb of 90F will be used for sizing the cooling towers because the actual design value is above the limit in G3.1.3.11.") | ||
| end |
There was a problem hiding this comment.
Are these in line with what's accepted by the EnergyPlus cooling tower models? It looks like we're using slightly different values there: https://github.com/NREL/openstudio-standards/blob/master/lib/openstudio-standards/prototypes/common/objects/Prototype.CoolingTower.rb#L21-L32
There was a problem hiding this comment.
Oh I'm not aware of what's acceptable.
|
@JanghyunJK do you still want this merged? can you address Jeremy's comment? |
|
@mdahlhausen I don't necessarily need this. Just wanted to add a missing piece while I was looking at it. I made changes just now based on @lymereJ suggestion (I think). But I'm really unsure about that comment regarding the accepted ranges of cooling tower parameters. |
|
@JanghyunJK - Thanks for following up! Could you please also address this comment: #1916 (comment). It would be great to have a small unit test as well. |
Pull request overview
coming from this:
plant_loop_prm_baseline_condenser_water_temperaturesfor 90.1-2019 #1915adding subclasses in 90.1-2016 and 2019
for this method:
plant_loop_prm_baseline_condenser_water_temperatureswhich reflects this section:
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.