-
Notifications
You must be signed in to change notification settings - Fork 19
Finish windfarmscadapower #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #192 by adding a new example demonstrating the WindFarmSCADAPower component, which allows simulating wind farms using SCADA power data instead of wind speed data.
Key Changes
- New example directory
00b_wind_farm_scada_powerwith runscript, configuration, plotting, and documentation - Enhanced input generation script to produce SCADA power data alongside wind speed data
- Updated utility functions to track the new
scada_input.ftrfile
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
hercules/utilities_examples.py |
Updated documentation and file tracking to include new scada_input.ftr file |
examples/inputs/00_generate_wind_history_small.py |
Extended to generate turbine power data using cubic wind speed approximation |
examples/00b_wind_farm_scada_power/hercules_input.yaml |
Configuration file for WindFarmSCADAPower example |
examples/00b_wind_farm_scada_power/hercules_runscript.py |
Main simulation script with controller that toggles turbine 0 power setpoint |
examples/00b_wind_farm_scada_power/plot_outputs.py |
Plotting script to visualize simulation outputs |
examples/00b_wind_farm_scada_power/README.md |
Documentation describing the example setup and usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR is meant to address #192. Based on that issue what is needed is:
WindFarmSCADAPowerWindFarmSCADAPower(although note this might not be necessary, pending discussion in WindFarmSCADAPower class testing and examples #192)WindFarmSCADAPower(although note this might not be necessary, pending discussion in WindFarmSCADAPower class testing and examples #192)Some secondary issues to address before merging