-
Notifications
You must be signed in to change notification settings - Fork 181
Update isort requirement from ~=5.0 to >=5,<8 #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the requirements on [isort](https://github.com/PyCQA/isort) to permit the latest version. - [Release notes](https://github.com/PyCQA/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.0.0...7.0.0) --- updated-dependencies: - dependency-name: isort dependency-version: 7.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🤠 soo many emails! But it's nice that it all happens quickly. |
|
Yeah, and considering this is the first time this it has run, I guess 4 issues it found isn't too bad---hopefully it'll be less going forward. But now I guess the question is what to do with them---in particular, I'd want to be careful with the |
|
Yep I agree. Pytest and isort are whatever, but the docs have been painful in the past. Maybe those would be resolved by building the docs locally and checking. I'm happy to help if you want to go that route |
Agree as well, on some other repos, maybe FLORIS too, I've found to avoid some errors we need to intentionally hold jupyter-book back. Maybe though this is a nudge to fix the underlying issues and make the docs build with latest jupyter-book? Would be a separate PR. |
|
Closing in favor of #1172 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on isort to permit the latest version.
Release notes
Sourced from isort's releases.
Changelog
Sourced from isort's changelog.
... (truncated)
Commits
0a09c78Merge pull request #2433 from DanielNoord/python-3140fee794Add 3.14 tostdlibds332a1adBumpzstandardfor 3.14 compatf756e56Merge pull request #2432 from DanielNoord/ruff-it-up52f5134Format withruffinstead ofblack012aa69Merge pull request #2431 from DanielNoord/ruff-it-up89773dbTarget 3.10 withruff933e382Merge pull request #2430 from DanielNoord/drop-398b6e00cRemove support for Python 3.9b5f9f29Bump profile plugin to 3.10+ and re-lockDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)