[BUGFIX] Specify resolution in scipy yaw optimization regression test #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulf81
approved these changes
Aug 12, 2025
Collaborator
paulf81
left a comment
paulf81
left a comment
There was a problem hiding this comment.
Agree with this solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PRs #1126 , #1129 , #1134 #1135 have had the
test_scripy_yaw_optfail for python versions 3.11, 3.12, and 3.13. It appears there is some minor numeric change in the outcome of the scipy optimization. This PR simply adds a resolution to the regression test to specify that the values only need to match to a relative tolerance of 1x10^-5 and an absolute tolerance of 0.01. For optimal yaw angles, a difference at the third decimal place is inconsequential.I've already made a fix for this on #1126 and #1129, but I decided to fix it in a standalone PR. Once this is merged, I will back merge develop into those branches.