-
Notifications
You must be signed in to change notification settings - Fork 23
Notebook restructuring #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #302 +/- ##
===============================================
+ Coverage 71.66% 74.67% +3.01%
===============================================
Files 40 41 +1
Lines 4524 4813 +289
===============================================
+ Hits 3242 3594 +352
+ Misses 1282 1219 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RDaxini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-springer I resolved conflicts, removing the pysam notebook (#252) and retaining the modified nbval and 05 advanced pysam notebook from this pr
This pull request introduces significant improvements to the project’s development workflow, documentation, and automation. The main themes are: migration of notebooks and scripts to a new
tutorialsdirectory structure, enhancements to CI/CD pipelines (including deployment and publishing workflows), and improved contributor documentation. These changes streamline maintenance, clarify contribution processes, and ensure compatibility with modern tooling.Directory and Notebook Structure Migration:
tutorials_and_toolsare migrated to a new, cleanertutorialsdirectory structure across CI/CD workflows, pre-commit config, and environment setup, including notebook paths and requirements files. [1] [2] [3] [4] [5] [6] [7]nbval.yaml,testbook.yaml) are updated to match the new directory and naming conventions, improving organization and maintainability. [1] [2]CI/CD Workflow Enhancements:
mainanddevelopmentbranches, and switches to thepeaceiris/actions-gh-pagesaction for more flexible branch previews and artifact deployment. [1] [2] [3]tutorials/**/scripts/andtools/**/scripts/from linting, improving performance and relevance. [1] [2]Contributor and Documentation Improvements:
CONTRIBUTING.mdprovides a clear, concise quickstart guide for developers, with links to detailed documentation, database contribution instructions, and pre-commit usage..readthedocs.yamland updating publication links inREADME.md. [1] [2]Other Maintenance:
These changes collectively modernize the project structure, improve automation, and make contributing easier for new and existing developers.This pull request reorganizes the project’s notebook and tool directories, updates configuration files to reflect the new structure, and improves the notebook testing and formatting workflows. The main changes include moving notebooks from
tutorials_and_toolsto a newtutorialsdirectory, introducing a dedicatedtoolsdirectory for standalone computational tools, updating workflow and pre-commit configurations, and adding support for notebook/script synchronization and formatting.Directory and Notebook Reorganization:
tutorials_and_tools/tutorials_and_tools/to a new, cleanertutorials/directory, and standalone computational tools have been moved to a newtools/directory. Workflow and configuration files have been updated to reference these new locations. [1] [2] [3] [4] [5]Workflow and Environment Updates:
nbval.yaml) and testing (testbook.yaml) have been updated to use the newtutorials/requirements.txtand reference the reorganized notebook paths. [1] [2]Pre-commit and Formatting Improvements:
.pre-commit-config.yamlfile now excludes the newtutorialsandtoolsdirectories from certain hooks, and adds a new hook forjupytextto sync notebooks with scripts and applyblackformatting.jupytext.tomlconfiguration file is added to define notebook/script synchronization and metadata filtering.Tool Documentation and Dependency Updates:
tools/README.mdwith documentation for each standalone tool and their requirements.pyproject.tomldependencies now includejupytextfor notebook/script synchronization.Notebook Code Style Consistency:
toolsdirectory have been updated for consistent code style, including formatting, string quoting, and minor code cleanups. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist before requesting a review