-
Notifications
You must be signed in to change notification settings - Fork 19
feat: hide sensitive info #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…references controller
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1745 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! This looks like a great implementation. Thanks for this!
However, the way it visually looks needs a little debating from the whole team which can be discussed better in the next meeting. If you can and have the time, you could maybe create different versions of how it looks based on your opinion and then we get back to you with the one we think it's the best in the meeting. What do you think?
Some people pointed out that they do not like the overall blur and prefer the widget to be completely hidden and show a button instead of it named "Show average" or something like that.
Others did not like how the blur was on the whole widget, maybe just on the numbers would be good.
Therefore, creating different versions would allow the team to get a better view on how this could be well implemented!
Thanks again!
Closes #1707
Added a new "Hide sensitive info" toggle in the profile settings. When enabled, the average grade and ECTS bar in the academic path page are blurred by default. The user can tap the blurred section to reveal it, and users with the option disabled can also tap on the section to blur or unblur the information as needed.
Review checklist
View Changes
Performance