FLAGSAPI-1046 return 400 if we cannot retrieve job role code#648
Merged
stuartmcneill1-nhs merged 14 commits intomasterfrom Jun 17, 2025
Merged
Conversation
if we are unable to retrieve the users job role code
- corrected path problem when building attachment resource url - corrected documentation to advise using combined auth-authentication
gps035
reviewed
Jun 9, 2025
gps035
reviewed
Jun 9, 2025
…ub.com:NHSDigital/summary-care-record-api into FLAGSAPI-1046-return-400-on-failed-user-lookup
gps035
reviewed
Jun 16, 2025
docker/service/src/main/java/uk/nhs/adaptors/scr/services/AcsService.java
Outdated
Show resolved
Hide resolved
… python 3.9 in run-tests yaml files
gps035
approved these changes
Jun 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change AcsService getUserRoleCodeAndId() to throw a BadRequestException if we are unable to retrieve the users job role code
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.