Skip to content

Remove duplicate publish checks#282

Merged
colinrotherham merged 1 commit intomainfrom
duplicate-publish-checks
Oct 8, 2025
Merged

Remove duplicate publish checks#282
colinrotherham merged 1 commit intomainfrom
duplicate-publish-checks

Conversation

@colinrotherham
Copy link
Collaborator

@colinrotherham colinrotherham commented Oct 8, 2025

This PR removes the duplicate yarn lint && yarn test checks from the prepublishOnly script

They're already run via GitHub Action release.yml workflow steps

It fixes the issue publishing v6.0.0-beta.1 where JS-DevTools/npm-publish@v1 likely sets NODE_ENV=production which overrides the Babel @babel/preset-env modules transform as shown below:

// Apply ES module transforms for Jest
// https://jestjs.io/docs/ecmascript-modules
modules: NODE_ENV === 'test' ? 'auto' : false,

The lines above set modules: false to prevent ES modules being transformed by default

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

@colinrotherham
Copy link
Collaborator Author

Thanks @edwardhorsford

We'll know fairly quickly if this worked or not, I'll tag v6.0.0-beta.1 again and see what happens

@colinrotherham colinrotherham added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit dcc0180 Oct 8, 2025
3 checks passed
@colinrotherham colinrotherham deleted the duplicate-publish-checks branch October 8, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants