Merged
Conversation
|
edwardhorsford
approved these changes
Oct 8, 2025
Collaborator
Author
|
Thanks @edwardhorsford We'll know fairly quickly if this worked or not, I'll tag v6.0.0-beta.1 again and see what happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR removes the duplicate
yarn lint && yarn testchecks from theprepublishOnlyscriptThey're already run via GitHub Action release.yml workflow steps
It fixes the issue publishing v6.0.0-beta.1 where JS-DevTools/npm-publish@v1 likely sets
NODE_ENV=productionwhich overrides the Babel@babel/preset-envmodules transform as shown below:nhsuk-react-components/babel.config.cjs
Lines 22 to 24 in 3b2974c
The lines above set
modules: falseto prevent ES modules being transformed by default