Ncrs 4111/ncrs 4106/upgrade of react storybook and scss#268
Closed
ricksmith130 wants to merge 23 commits intomainfrom
Closed
Ncrs 4111/ncrs 4106/upgrade of react storybook and scss#268ricksmith130 wants to merge 23 commits intomainfrom
ricksmith130 wants to merge 23 commits intomainfrom
Conversation
|
Author
|
CLosing PR until updating yarn in the pipeline is discussed with Sam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an upgrade to React 19, storybook, scss.
IMPORTANT
You will see a lot of changes around react types, this is mostly because thinks like FC and HTMLProps are no longer exported and need to be taken from the React import itself (not a nice change). In some other cases I have created refs to replace deprecated ones line MutableRef etc.