add width and height the NHS logo as per the core library#173
add width and height the NHS logo as per the core library#173chrimesdev wants to merge 1 commit intoNHSDigital:mainfrom
Conversation
The NHS logo was missing a width and height attribute causing some validation issues. https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369
KaiSpencer
left a comment
There was a problem hiding this comment.
Brill, thank you @chrimesdev
|
Hi both - Developers on my team have gotten back to me with some additional validation issues with this. This is the message I've received from them:
This slack thread has a screenshot of the the validation errors being received |
|
The |
|
@Tomdango I don't have merging permissions, could you take a look and do the thing :) |
|
I'm going to close this one We've got all the latest icons and the new header with account information in #267 |
The NHS logo was missing a width and height attribute causing some validation issues.
There also seems to be a few extra attributes that might not be needed - but will leave for now. See the markup at: https://service-manual.nhs.uk/design-system/components/header
https://nhs-service-manual.slack.com/archives/CDJ29AQCD/p1686240007585369