NRL-1811 do not log multiple pointer warning if test patient#1114
Merged
katebobyn-nhs merged 3 commits intodevelopfrom Jan 5, 2026
Merged
Conversation
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
Contributor
sandyforresternhs
left a comment
sandyforresternhs
left a comment
There was a problem hiding this comment.
Changes look good 👍 . We've got tests that assert logs are created when multiple pointers are detected - would it be worth adding an assertion to show it doesn't log in relation to test patients?
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
had a problem deploying
to
pull-request
GitHub Actions
Failure
|
💥 Something went wrong while building the pull request environment. |
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
sandyforresternhs
approved these changes
Dec 31, 2025
katebobyn-nhs
deleted the
feature/kabo5-NRL-1811-ignore-duplicate-warnings-for-test-nhs-nos
branch
katebobyn-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.