NRL-1860 Tweak prep scripts to support NFT runs#1111
Merged
anjalitrace2-nhs merged 8 commits intodevelopfrom Dec 18, 2025
Merged
NRL-1860 Tweak prep scripts to support NFT runs#1111anjalitrace2-nhs merged 8 commits intodevelopfrom
anjalitrace2-nhs merged 8 commits intodevelopfrom
Conversation
…nts. Output .csv file for test once nft table has been seeded
…ket for perf-test env
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
|
🚀 PR environment successfully deployed. |
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
mattdean3-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
anjalitrace2-nhs
previously approved these changes
Dec 16, 2025
Contributor
anjalitrace2-nhs
left a comment
anjalitrace2-nhs
left a comment
There was a problem hiding this comment.
One minor non-blocking comment, looks good to me! ✅
scripts/seed_nft_tables.py
Outdated
Comment on lines
284
to
297
| # def _set_up_count_iterator(pointers_per_px: float) -> iter: | ||
| # """ | ||
| # Given a target average number of pointers per patient, | ||
| # generates a distribution of counts per individual patient. | ||
| # """ | ||
| # | ||
| # extra_per_hundred = int( | ||
| # (pointers_per_px - 1.0) * 100 | ||
| # ) # no patients can have zero pointers | ||
| # counts = {} | ||
| # counts["3"] = extra_per_hundred // 10 | ||
| # counts["2"] = extra_per_hundred - 2 * counts["3"] | ||
| # counts["1"] = 100 - counts[2] - counts[3] | ||
| # return _set_up_cyclical_iterator(counts) |
Contributor
There was a problem hiding this comment.
super minor: do we need this or can we bin it?
mattdean3-nhs
had a problem deploying
to
pull-request
GitHub Actions
Error
mattdean3-nhs
had a problem deploying
to
pull-request
GitHub Actions
Error
anjalitrace2-nhs
approved these changes
Dec 18, 2025
|
anjalitrace2-nhs
temporarily deployed
to
pull-request
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.